[PPL-devel] [GIT] ppl/ppl(master): Avoid implicit conversion changing signedness.

Abramo Bagnara abramo.bagnara at gmail.com
Fri Feb 24 16:53:12 CET 2012


Module: ppl/ppl
Branch: master
Commit: 7cfc3f1609b01c51c1a402012bb313a95f847e61
URL:    http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=7cfc3f1609b01c51c1a402012bb313a95f847e61

Author: Abramo Bagnara <abramo.bagnara at gmail.com>
Date:   Fri Feb 24 16:52:21 2012 +0100

Avoid implicit conversion changing signedness.
Detected by ECLAIR service utypflag.

---

 interfaces/C/ppl_c_implementation_common.cc       |   12 ++++++------
 interfaces/C/ppl_interface_generator_c_cc_code.m4 |    2 +-
 src/checked_float.inlines.hh                      |    2 +-
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/interfaces/C/ppl_c_implementation_common.cc b/interfaces/C/ppl_c_implementation_common.cc
index ee8a2eb..f5a6eac 100644
--- a/interfaces/C/ppl_c_implementation_common.cc
+++ b/interfaces/C/ppl_c_implementation_common.cc
@@ -306,25 +306,25 @@ CATCH_ALL
 
 int
 ppl_version_major(void) try {
-  return version_major();
+  return static_cast<int>(version_major());
 }
 CATCH_ALL
 
 int
 ppl_version_minor(void) try {
-  return version_minor();
+  return static_cast<int>(version_minor());
 }
 CATCH_ALL
 
 int
 ppl_version_revision(void) try {
-  return version_revision();
+  return static_cast<int>(version_revision());
 }
 CATCH_ALL
 
 int
 ppl_version_beta(void) try {
-  return version_beta();
+  return static_cast<int>(version_beta());
 }
 CATCH_ALL
 
@@ -1903,7 +1903,7 @@ int
 ppl_MIP_Problem_number_of_constraints(ppl_const_MIP_Problem_t mip,
 				      ppl_dimension_type* m) try {
   const MIP_Problem& mmip = *to_const(mip);
-  *m = mmip.constraints_end() - mmip.constraints_begin();
+  *m = static_cast<ppl_dimension_type>(mmip.constraints_end() - mmip.constraints_begin());
   return 0;
 }
 CATCH_ALL
@@ -2188,7 +2188,7 @@ int
 ppl_PIP_Problem_number_of_constraints(ppl_const_PIP_Problem_t pip,
 				      ppl_dimension_type* m) try {
   const PIP_Problem& ppip = *to_const(pip);
-  *m = ppip.constraints_end() - ppip.constraints_begin();
+  *m = static_cast<ppl_dimension_type>(ppip.constraints_end() - ppip.constraints_begin());
   return 0;
 }
 CATCH_ALL
diff --git a/interfaces/C/ppl_interface_generator_c_cc_code.m4 b/interfaces/C/ppl_interface_generator_c_cc_code.m4
index ec24f9c..3bf5ce3 100644
--- a/interfaces/C/ppl_interface_generator_c_cc_code.m4
+++ b/interfaces/C/ppl_interface_generator_c_cc_code.m4
@@ -184,7 +184,7 @@ ppl_ at CLASS@_relation_with_@!RELATION_REPRESENT@
  ppl_const_@!RELATION_REPRESENT at _t c) try {
   const @CPP_CLASS@& pph = *to_const(ph);
   const @!RELATION_REPRESENT@& cc = *to_const(c);
-  return pph.relation_with(cc).get_flags();
+  return static_cast<int>(pph.relation_with(cc).get_flags());
 }
 CATCH_ALL
 
diff --git a/src/checked_float.inlines.hh b/src/checked_float.inlines.hh
index ae6373f..79166c0 100644
--- a/src/checked_float.inlines.hh
+++ b/src/checked_float.inlines.hh
@@ -840,7 +840,7 @@ assign_float_mpz(T& to, const mpz_class& from, Rounding_Dir dir) {
   else
     mpz_mul_2exp(mantissa, from_z, Float<T>::Binary::MANTISSA_BITS - exponent);
   Float<T> f;
-  f.u.binary.build(sign < 0, mantissa, exponent);
+  f.u.binary.build(sign < 0, mantissa, static_cast<long>(exponent));
   mpz_clear(mantissa);
   to = f.value();
   if (meaningful_bits > Float<T>::Binary::MANTISSA_BITS) {




More information about the PPL-devel mailing list