[PPL-devel] [GIT] ppl/ppl(master): Prefer testing against zero.

Enea Zaffanella zaffanella at cs.unipr.it
Wed Feb 15 15:21:17 CET 2012


Module: ppl/ppl
Branch: master
Commit: 0691decf11e6f384b602d762c3060af30bf43a50
URL:    http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=0691decf11e6f384b602d762c3060af30bf43a50

Author: Enea Zaffanella <zaffanella at cs.unipr.it>
Date:   Wed Feb 15 15:21:01 2012 +0100

Prefer testing against zero.

---

 src/checked_float.inlines.hh |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/checked_float.inlines.hh b/src/checked_float.inlines.hh
index ffb5bd0..6c2b97a 100644
--- a/src/checked_float.inlines.hh
+++ b/src/checked_float.inlines.hh
@@ -190,14 +190,14 @@ template <typename Policy, typename T>
 inline bool
 is_minf_float(const T v) {
   Float<T> f(v);
-  return CHECK_P(Policy::has_infinity, (f.u.binary.inf_sign() == -1));
+  return CHECK_P(Policy::has_infinity, (f.u.binary.inf_sign() < 0));
 }
 
 template <typename Policy, typename T>
 inline bool
 is_pinf_float(const T v) {
   Float<T> f(v);
-  return CHECK_P(Policy::has_infinity, (f.u.binary.inf_sign() == 1));
+  return CHECK_P(Policy::has_infinity, (f.u.binary.inf_sign() > 0));
 }
 
 
@@ -233,7 +233,7 @@ pred_float(T& v) {
   Float<T> f(v);
   PPL_ASSERT(!f.u.binary.is_nan());
   PPL_ASSERT(f.u.binary.inf_sign() >= 0);
-  if (f.u.binary.zero_sign() == 1) {
+  if (f.u.binary.zero_sign() > 0) {
     f.u.binary.negate();
     f.u.binary.inc();
   }
@@ -252,7 +252,7 @@ succ_float(T& v) {
   Float<T> f(v);
   PPL_ASSERT(!f.u.binary.is_nan());
   PPL_ASSERT(f.u.binary.inf_sign() <= 0);
-  if (f.u.binary.zero_sign() == -1) {
+  if (f.u.binary.zero_sign() < 0) {
     f.u.binary.negate();
     f.u.binary.inc();
   }




More information about the PPL-devel mailing list