[PPL-devel] [GIT] ppl/ppl(master): Dealt with a FIXME in PIP_Solution_Node::solve().

Enea Zaffanella zaffanella at cs.unipr.it
Thu Feb 18 15:05:11 CET 2010


Module: ppl/ppl
Branch: master
Commit: ee564d807b24ca244ac691498a4bb684b12898b4
URL:    http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=ee564d807b24ca244ac691498a4bb684b12898b4

Author: Enea Zaffanella <zaffanella at cs.unipr.it>
Date:   Thu Feb 18 15:01:45 2010 +0100

Dealt with a FIXME in PIP_Solution_Node::solve().

---

 src/PIP_Tree.cc |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/src/PIP_Tree.cc b/src/PIP_Tree.cc
index 4f08797..67986a1 100644
--- a/src/PIP_Tree.cc
+++ b/src/PIP_Tree.cc
@@ -1824,9 +1824,7 @@ PIP_Solution_Node::solve(const PIP_Problem& problem,
         // Do nothing if the j-th pivot element is zero.
         if (s_pivot_j == 0)
           continue;
-        // FIXME: why iterating downwards makes a difference?
-        // for (dimension_type i = num_rows; i-- > 0; ) {
-        for (dimension_type i = 0; i < num_rows; ++i) {
+        for (dimension_type i = num_rows; i-- > 0; ) {
           Row& s_i = tableau.s[i];
           product = s_pivot_j * s_i[pj];
           if (product % s_pivot_pj != 0) {




More information about the PPL-devel mailing list