[PPL-devel] [GIT] ppl/ppl(master): Documented ROUND_NOT_NEEDED FIXME.
Abramo Bagnara
abramo.bagnara at gmail.com
Sat Mar 28 15:37:18 CET 2009
Module: ppl/ppl
Branch: master
Commit: 2630163750d742439996c9755a4c690bdea08421
URL: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=2630163750d742439996c9755a4c690bdea08421
Author: Abramo Bagnara <abramo.bagnara at gmail.com>
Date: Sat Mar 28 15:37:39 2009 +0100
Documented ROUND_NOT_NEEDED FIXME.
---
src/Checked_Number.inlines.hh | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/src/Checked_Number.inlines.hh b/src/Checked_Number.inlines.hh
index cbde0bd..774c69d 100644
--- a/src/Checked_Number.inlines.hh
+++ b/src/Checked_Number.inlines.hh
@@ -45,8 +45,12 @@ inline Result
check_result(Result r, Rounding_Dir dir) {
if (dir == ROUND_NOT_NEEDED && !is_special(r)) {
#ifdef DEBUG_ROUND_NOT_NEEDED
- // FIXME(0.10.1): this is wrong. If an overflow happens the Result may be
+ // FIXME: this is wrong. If an overflow happens the Result may be
// V_LT or V_GT. What's the better way to cope with that?
+
+ // To solve this we need to clarify if ROUND_NOT_NEEDED is
+ // specified to grant library that the result will be exact _and_
+ // not overflowing or the result will be exact _or_ overflowling.
assert(r == V_EQ);
#else
return V_EQ;
More information about the PPL-devel
mailing list