[PPL-devel] [GIT] ppl/ppl(master): Dealt with a FIXME related to variable names.

[Enea Zaffanella]

Module: ppl/ppl
Branch: master
Commit: 019b1eb83a88653d3293d596e3d0f2eabf4a8d1f
URL:    http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=019b1eb83a88653d3293d596e3d0f2eabf4a8d1f

Author: Enea Zaffanella <zaffanella at cs.unipr.it>
Date:   Sun Mar 22 13:54:28 2009 +0100

Dealt with a FIXME related to variable names.

---

 src/Octagonal_Shape.templates.hh |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/Octagonal_Shape.templates.hh b/src/Octagonal_Shape.templates.hh
index 08aadd4..ef78d2a 100644
--- a/src/Octagonal_Shape.templates.hh
+++ b/src/Octagonal_Shape.templates.hh
@@ -1631,10 +1631,8 @@ Octagonal_Shape<T>::relation_with(const Generator& g) const {
         ? Coefficient_zero()
         : g.coefficient(y);
 
-      // FIXME(0.10.1)! Find better names.
-      const bool is_binary_equality = is_additive_inverse(m_ii_jj, m_i_j);
-      const bool is_a_binary_equality = is_additive_inverse(m_i_jj, m_ii_j);
-      if (is_binary_equality) {
+      const bool difference_is_equality = is_additive_inverse(m_ii_jj, m_i_j);
+      if (difference_is_equality) {
         // The constraint has form ax - ay = b.
         // The scalar product has the form
         // 'den * coeff_x - den * coeff_y - num * g.divisor()'.
@@ -1698,7 +1696,8 @@ Octagonal_Shape<T>::relation_with(const Generator& g) const {
         }
       }
 
-      if (is_a_binary_equality) {
+      const bool sum_is_equality = is_additive_inverse(m_i_jj, m_ii_j);
+      if (sum_is_equality) {
         // The constraint has form ax + ay = b.
         // The scalar product has the form
         // 'den * coeff_x + den * coeff_y - num * g.divisor()'.