[PPL-devel] [GIT] ppl/ppl(master): A couple of FIXME postponed to 0.11.

[Enea Zaffanella]

Module: ppl/ppl
Branch: master
Commit: 1160320355348e63c84b906fdd02af56983a2720
URL:    http://www.cs.unipr.it/git/gitweb.cgi?p=ppl/ppl.git;a=commit;h=1160320355348e63c84b906fdd02af56983a2720

Author: Enea Zaffanella <zaffanella at cs.unipr.it>
Date:   Thu Apr  2 13:23:20 2009 +0200

A couple of FIXME postponed to 0.11.

---

 src/Box.templates.hh               |    4 +++-
 tests/Box/refinewithconstraint1.cc |    4 ++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/Box.templates.hh b/src/Box.templates.hh
index 0c4d3c0..596057d 100644
--- a/src/Box.templates.hh
+++ b/src/Box.templates.hh
@@ -1939,6 +1939,8 @@ Box<ITV>::refine_no_check(const Constraint& c) {
   dimension_type c_num_vars = 0;
   dimension_type c_only_var = 0;
   // Non-interval constraints are ignored.
+  // FIXME: instead of ignoring, safely use propagate_no_check()
+  // (i.e., ensuring that no termination problem can arise).
   if (!extract_interval_constraint(c, c_space_dim, c_num_vars, c_only_var))
     return;
 
@@ -1947,7 +1949,7 @@ Box<ITV>::refine_no_check(const Constraint& c) {
     // Dealing with a trivial constraint.
     if (n < 0
         || (c.is_equality() && n != 0)
-	|| (c.is_strict_inequality() && n == 0))
+        || (c.is_strict_inequality() && n == 0))
       set_empty();
     return;
   }
diff --git a/tests/Box/refinewithconstraint1.cc b/tests/Box/refinewithconstraint1.cc
index c5d33fa..a126dcd 100644
--- a/tests/Box/refinewithconstraint1.cc
+++ b/tests/Box/refinewithconstraint1.cc
@@ -143,12 +143,12 @@ test04() {
 } // namespace
 
 BEGIN_MAIN
-// FIXME(0.10.1)
+// FIXME: see corresponding fixme in Box<ITV>::refine_no_check(c).
 // Temporarily set to always fail: this is meant to be a test for
 // constraint propagation, rather than syntactical refinement.
 //  DO_TEST_F8(test01);
   DO_TEST_F(test01);
-// FIXME(0.10.1)
+// FIXME: see corresponding fixme in Box<ITV>::refine_no_check(c).
 // Temporarily set to always fail: this is meant to be a test for
 // constraint propagation, rather than syntactical refinement.
 //  DO_TEST(test02);