[PURRS-devel] Re: One last time: annoying warning

[Roberto Bagnara]

Gabriel Dos Reis wrote:
> Roberto Bagnara <bagnara at cs.unipr.it> writes:
> 
> [...]
> 
> | What is important is that the GCC people taking care of the standard
> | library do the right thing.  Since they know that someone may very
> | legitimately wish to compile with, e.g., -W -Wall, they write code
> | like
> | 
> |        virtual iter_type
> |        do_get_time(iter_type __s, iter_type /*__end*/, ios_base&,
> |                    ios_base::iostate& /*__err*/, tm* /*__t*/) const
> |        { return __s; }
> 
> I'm one of those GCC people taking care of the library and I can
> assure you I don't particularly appreciate that style (like some other
> things in the V3 STYLE).  So, I would say that you should be very
> careful in drawing conclusions from things you might read in the V3
> source code -- not every one has the same idea of the styles to be used.

It is not a matter of style: it is a matter of respect for the users.

> [...]
> 
> | (stl_alloc.h, lines 120 ff.), ..., you will find hundreds of examples
> | like that.  Naturally, I am really thankful they do that.
> 
> Naturally you'll also see the opposite:
>>From stl_algobase.h:
> 
>      template<typename _InputIter, typename _OutputIter>
> 	inline _OutputIter
> 	__copy(_InputIter __first, _InputIter __last,
> 	       _OutputIter __result,
> 	       input_iterator_tag)
>      template<typename _InputIter, typename _OutputIter>
> 	inline _OutputIter
> 	__copy(_InputIter __first, _InputIter __last,
> 	       _OutputIter __result,
> 	       input_iterator_tag)
> 
> and so one.

Huh?  Looks like a copy-and-paste error...


-- 
Prof. Roberto Bagnara
Computer Science Group
Department of Mathematics, University of Parma, Italy
http://www.cs.unipr.it/~bagnara/
mailto:bagnara at cs.unipr.it